[PATCH] Fix crash in handling back-end warnings

Diego Novillo dnovillo at google.com
Fri May 8 08:42:00 PDT 2015


On Fri, May 8, 2015 at 8:28 AM, Duncan P. N. Exon Smith
<dexonsmith at apple.com> wrote:

> I probably broke this at some point when I was transitioning
> to the new debug info hierarchy.  The old hierarchy's accessors
> checked for NULL and give default answers, whereas the new hierarchy
> just uses pointers directly.
>
> At some point I switched the accessors to start asserting and fixed
> any bugs that uncovered, but I guess there wasn't any test coverage
> here so I missed it.

Yeah. The backend tests that we have for diagnostics all include debug
info and if you go via the FE, it always makes sure that debuglocs are
always generated.

Geoff, your patch LGTM.  Thanks for the fix!


Diego.



More information about the cfe-commits mailing list