[PATCH] Fix crash in handling back-end warnings

Diego Novillo dnovillo at google.com
Thu May 7 14:42:51 PDT 2015


On Thu, May 7, 2015 at 2:42 PM, Diego Novillo <dnovillo at google.com> wrote:
> On Fri, May 1, 2015 at 3:22 PM, Geoff Berry <gberry at codeaurora.org> wrote:
>
>> Index: lib/CodeGen/CodeGenAction.cpp
>> ===================================================================
>> --- lib/CodeGen/CodeGenAction.cpp
>> +++ lib/CodeGen/CodeGenAction.cpp
>> @@ -434,7 +434,13 @@
>>    FileManager &FileMgr = SourceMgr.getFileManager();
>>    StringRef Filename;
>>    unsigned Line, Column;
>> -  D.getLocation(&Filename, &Line, &Column);
>> +  if (D.isLocationAvailable())
>> +    D.getLocation(&Filename, &Line, &Column);
>> +  else {
>> +    Filename = "<unknown>";
>> +    Line = 0;
>> +    Column = 0;
>> +  }
>
> Odd, this code used to unavailable locations

"used to deal with unavailable..."



More information about the cfe-commits mailing list