[PATCH] Protection against stack-based memory corruption errors using SafeStack: compiler-rt runtime support library

[Peter Collingbourne]

================
Comment at: lib/CMakeLists.txt:12
@@ -11,2 +11,3 @@
   add_subdirectory(ubsan)
+  add_subdirectory(safestack)
 endif()
----------------
samsonov wrote:
> I thought you need to add this if `COMPILER_RT_HAS_SAFESTACK` is true.
Done

================
Comment at: test/safestack/CMakeLists.txt:5
@@ +4,3 @@
+if(NOT COMPILER_RT_STANDALONE_BUILD)
+  list(APPEND SAFESTACK_TEST_DEPS safestack clang)
+endif()
----------------
samsonov wrote:
> I believe you also need `${SANIITIZER_COMMON_LIT_TEST_DEPS}`
Done

================
Comment at: test/safestack/check-overflow.c:5
@@ +4,3 @@
+// RUN: %clang_nosafestack -fno-stack-protector %s -o %t
+// RUN: %run ! %t
+
----------------
samsonov wrote:
> use not (here and below)
Done

================
Comment at: test/safestack/lit.site.cfg.in:5
@@ +4,3 @@
+# Tool-specific config options.
+config.safestack_lit_binary_dir = "@SAFESTACK_LIT_BINARY_DIR@"
+
----------------
samsonov wrote:
> You don't use this attribute anywhere, delete it.
Done

http://reviews.llvm.org/D6096

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/