r236422 - Revert "Frontend: Stop leaking when not -disable-free"

[Duncan P. N. Exon Smith]

> On 2015 May 4, at 09:01, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> Author: dexonsmith
> Date: Mon May  4 08:01:42 2015
> New Revision: 236422
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=236422&view=rev
> Log:
> Revert "Frontend: Stop leaking when not -disable-free"
> 
> This reverts commit r236419, since it caused some bots to fail.  On:
> 
> http://lab.llvm.org:8011/builders/clang-hexagon-elf/builds/26124
> http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/35086

Also failed on:

http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/26099

Can anyone with access to a Linux box investigate?  It's not
clear to me what's going on here, since the tests pass locally
(on Darwin).

> 
> these tests:
> 
> FAIL: Clang::import-decl.cpp
> FAIL: Clang::floating-literal.c
> FAIL: Clang::x86_64-linux-android.c
> 
> fail with this output:
> 
> Command Output (stderr):
> --
> Stack dump:
> 0.  Program arguments: /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/clang -cc1 -internal-isystem /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../lib/clang/3.7.0/include -nostdsysteminc -ast-print -x ast -
> /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/tools/clang/test/Modules/Output/import-decl.cpp.script: line 3:  9665 Segmentation fault      (core dumped) /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/clang -cc1 -internal-isystem /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/../lib/clang/3.7.0/include -nostdsysteminc -ast-print -x ast - < /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/tools/clang/test/Modules/Output/import-decl.cpp.tmp.ast
>      9666 Done                    | /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.obj/Release+Asserts/bin/FileCheck /var/lib/buildbot/slaves/hexagon-build-03/clang-hexagon-elf/llvm.src/tools/clang/test/Modules/import-decl.cpp
> 
> --
> 
> Modified:
>    cfe/trunk/lib/Frontend/FrontendAction.cpp
> 
> Modified: cfe/trunk/lib/Frontend/FrontendAction.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/FrontendAction.cpp?rev=236422&r1=236421&r2=236422&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Frontend/FrontendAction.cpp (original)
> +++ cfe/trunk/lib/Frontend/FrontendAction.cpp Mon May  4 08:01:42 2015
> @@ -494,20 +494,13 @@ void FrontendAction::EndSourceFile() {
>   // FrontendAction.
>   CI.clearOutputFiles(/*EraseFiles=*/shouldEraseOutputFiles());
> 
> +  // FIXME: Only do this if DisableFree is set.
>   if (isCurrentFileAST()) {
> -    if (DisableFree) {
> -      CI.resetAndLeakSema();
> -      CI.resetAndLeakASTContext();
> -      CI.resetAndLeakPreprocessor();
> -      CI.resetAndLeakSourceManager();
> -      CI.resetAndLeakFileManager();
> -    } else {
> -      CI.setSema(nullptr);
> -      CI.setASTContext(nullptr);
> -      CI.setPreprocessor(nullptr);
> -      CI.setSourceManager(nullptr);
> -      CI.setFileManager(nullptr);
> -    }
> +    CI.resetAndLeakSema();
> +    CI.resetAndLeakASTContext();
> +    CI.resetAndLeakPreprocessor();
> +    CI.resetAndLeakSourceManager();
> +    CI.resetAndLeakFileManager();
>   }
> 
>   setCompilerInstance(nullptr);
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits