[PATCH] noexcept expressions with overloaded functions

Aaron Ballman aaron at aaronballman.com
Mon Apr 27 15:34:40 PDT 2015


Thanks! Commit in r235931

~Aaron

On Mon, Apr 27, 2015 at 6:18 PM, Richard Smith <richard at metafoo.co.uk> wrote:
> On Mon, Apr 27, 2015 at 2:52 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
>>
>> On Mon, Apr 27, 2015 at 5:41 PM, Richard Smith <richard at metafoo.co.uk>
>> wrote:
>> > This should call CheckPlaceholderExpr instead of just checking for the
>> > OverloadExpr case; there are a bunch of other kinds of expression that
>> > we
>> > should handle here (property exprs, bound member functions, ...).
>>
>> Ooh, even better. Thank you for the suggestion; new attempt attached.
>
>
> LGTM, thanks!
>
>>
>>
>> ~Aaron
>>
>> >
>> > On Mon, Apr 27, 2015 at 2:34 PM, Aaron Ballman <aaron at aaronballman.com>
>> > wrote:
>> >>
>> >> This patch addresses PR15842 by checking whether the operand to the
>> >> noexcept expression is an unevaluted lookup expression. It reuses some
>> >> overload logic to generate a diagnostic and potentially reasonable
>> >> fixit.
>> >>
>> >> ~Aaron
>> >
>> >
>
>



More information about the cfe-commits mailing list