[PATCH] PR23175 (unit test) - Infinite loop iterating Objective-C method declarations in categories when the AST was deserialized from an .ast file

Tom Honermann thonermann at coverity.com
Wed Apr 22 12:07:42 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: include/clang/Tooling/Tooling.h:173
@@ -173,1 +172,3 @@
+                                          const Twine &FileName = "input.cc",
+                                          bool Reserialize = false);
 
----------------
klimek wrote:
> I don't think this is the right choice.
> It seems like we could provide two functions serialize and deserialize so that Reserialize=true becomes
> deserialize(serialize(buildASTFromCode(...))
> ?
Ah, yes.  I agree that better encapsulates separation of concerns.

http://reviews.llvm.org/D9126

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list