[PATCH] Don't dllimport/export class members with internal linkage (PR23308)

Hans Wennborg hans at chromium.org
Tue Apr 21 21:08:15 PDT 2015


I'll land this now to unbreak the Chromium build. If David or Reid has more comments, we can do follow-up patches.


================
Comment at: lib/Sema/SemaDeclCXX.cpp:4807
@@ -4806,1 +4806,3 @@
 
+    if (!cast<NamedDecl>(Member)->isExternallyVisible()) {
+      continue;
----------------
thakis wrote:
> nit: no braces
Done.

http://reviews.llvm.org/D9182

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list