[PATCH] [OPENMP] Fix use of unsigned counters in loops with zero trip count.

John McCall rjmccall at gmail.com
Tue Apr 21 12:42:53 PDT 2015


LGTM.


================
Comment at: lib/Sema/SemaOpenMP.cpp:2386
@@ +2385,3 @@
+Expr *OpenMPIterationSpaceChecker::BuildPreCond(Scope *S, Expr *Cond) const {
+  // Try to build LB ><>=<= UB.
+  bool Suppress = SemaRef.getDiagnostics().getSuppressAllDiagnostics();
----------------
Cute, but more distracting than helpful. :)  Maybe "Try to build LB <op> UB, where <op> is <, >, <=, or >=."

http://reviews.llvm.org/D9103

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list