[PATCH] Add a no_sanitize_vptr function attribute.

Alexey Samsonov vonosmas at gmail.com
Mon Apr 20 16:38:28 PDT 2015


In http://reviews.llvm.org/D9059#157697, @ochang wrote:

> In http://reviews.llvm.org/D9059#157331, @rsmith wrote:
>
> > I'm not convinced that adding one attribute per sanitizer is the right design here -- it doesn't seem to scale very well. Have you considered an attribute like
> >
> >   __attribute__((no_sanitize("list,of,sanitizers"))) void fn() { ... }
> >   
> >
> > where the list is parsed as if it were specified as `-fno-sanitize=list,of,sanitizers` on the command line?
>
>
> This does seem like a much better way of doing this. Should I change this in this patch?
>
> What does everyone else think?


I agree with this suggestion. It would be cool to have a single attribute like this, and later deprecate no_sanitize_address, no_sanitize_thread and no_sanitize_memory.


http://reviews.llvm.org/D9059

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list