r235190 - Remove the assertion as it was useless and broken.

Sylvestre Ledru sylvestre at debian.org
Fri Apr 17 06:21:40 PDT 2015


Author: sylvestre
Date: Fri Apr 17 08:21:39 2015
New Revision: 235190

URL: http://llvm.org/viewvc/llvm-project?rev=235190&view=rev
Log:
Remove the assertion as it was useless and broken.

Enforcing the assert caused the following tests to fail:
Clang :: Analysis__bstring.c
Clang :: Analysis__comparison-implicit-casts.cpp
Clang :: Analysis__malloc-interprocedural.c
Clang :: Analysis__malloc.c
Clang :: Analysis__redefined_system.c
Clang :: Analysis__string.c
Clang :: Analysis__weak-functions.c


Modified:
    cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp?rev=235190&r1=235189&r2=235190&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/CStringChecker.cpp Fri Apr 17 08:21:39 2015
@@ -1922,10 +1922,6 @@ bool CStringChecker::evalCall(const Call
   if (!evalFunction)
     return false;
 
-  // Make sure each function sets its own description.
-  // (But don't bother in a release build.)
-  assert(!(CurrentFunctionDescription == nullptr));
-
   // Check and evaluate the call.
   (this->*evalFunction)(C, CE);
 





More information about the cfe-commits mailing list