[PATCH] clang-format: [JS] Option for top-level dict literals on a single line

Daniel Jasper djasper at google.com
Fri Apr 17 02:38:50 PDT 2015


Unfortunately, this interacts non-trivially with http://reviews.llvm.org/rL232320. I can fix the merge, but I am not sure what the proposed behavior is. Could you outline what you would want the flag to do in these cases? Or does the other commit possibly fix your use case?


================
Comment at: unittests/Format/FormatTestJS.cpp:161-162
@@ -146,1 +160,4 @@
   verifyFormat("f({a: 1, b: 2, c: 3});");
+  verifyFormat("f({a: 1, b: 2, c: 3});",
+               singleLineDictLiteralsStyle(FormatStyle::SLS_All));
+  verifyFormat("f({\n"
----------------
We probably should be testing 'nested' here, too.

http://reviews.llvm.org/D7200

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list