[PATCH] Add hasUnderlyingType narrowing matcher for TypedefDecls

Manuel Klimek klimek at google.com
Thu Apr 16 10:18:41 PDT 2015


On Thu, Apr 16, 2015 at 9:26 AM Richard <legalize at xmission.com> wrote:

> In http://reviews.llvm.org/D8149#157110, @klimek wrote:
>
> > Argh, sorry for missing it - please always feel free to ping earlier
> (especially my reviews you can ping 2x per week).
> >  Can you please add a unit test? Apart from that it looks good.
>
>
> I added a `FileCheck` test in the tools-extra repository (see
> http://reviews.llvm.org/D8150).  Is that sufficient, or would you also
> like to see a unit test?
>

I'd like to see a unit test - we often make changes to the matcher
infrastructure assuming all matchers are at least unit tested.


>
>
> http://reviews.llvm.org/D8149
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150416/74b5e733/attachment.html>


More information about the cfe-commits mailing list