Argh, sorry for missing it - please always feel free to ping earlier (especially my reviews you can ping 2x per week). Can you please add a unit test? Apart from that it looks good. http://reviews.llvm.org/D8149 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/