lgtm I think the only other way to get shouldBeInCOMDAT to return true is with static data members of class templates, but those never get common linkage anyway. http://reviews.llvm.org/D9042 EMAIL PREFERENCES http://reviews.llvm.org/settings/panel/emailpreferences/