[PATCH] [CUDA] Allow using integral non-type template parameters as launch_bounds attribute arguments.
Artem Belevich
tra at google.com
Wed Apr 15 11:36:43 PDT 2015
Addressed Richard Smith's review comments:
- Consolidated attribute creation and argument checking into Sema::AddLaunchBoundsAttr() which is now used from both SemaDeclAttr.cpp and SemaTemplateInstantiateDecl.cpp
- Let Expr::isIntegerConstantExpr() do the job of checking and reporting argument type errors.
- Use DiagnoseUnexpandedParameterPack() to report parameter packs when we reject them.
http://reviews.llvm.org/D8985
Files:
include/clang/Basic/Attr.td
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/CodeGen/TargetInfo.cpp
lib/Sema/SemaDeclAttr.cpp
lib/Sema/SemaTemplateInstantiateDecl.cpp
test/CodeGenCUDA/launch-bounds.cu
test/SemaCUDA/launch_bounds.cu
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8985.23790.patch
Type: text/x-patch
Size: 14387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150415/0d4be46d/attachment.bin>
More information about the cfe-commits
mailing list