[PATCH] Enhance clang-tidy readability-simplify-boolean-expr check to handle chained conditional assignment and chained conditional return

[Richard]

================
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:41
@@ +40,3 @@
+///
+/// When a conditional boolean return appears at the end of a chain of `if`,
+/// `else if` statements, the conditional statement is left unchanged unless
----------------
alexfh wrote:
> I'd deduplicate some text here:
> 
>   /// When a conditional boolean return (or assignment) appears at the end
>   /// of a chain of `if`, `else if` statements, the conditional statement is left
>   /// unchanged unless the option `ChainedConditionalReturn`
>   /// (`ChainedConditionalAssignmentis for an assignment) specified as non-zero.
Fixed.

================
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.h:52
@@ +51,3 @@
+  SimplifyBooleanExprCheck(StringRef Name, ClangTidyContext *Context);
+  virtual ~SimplifyBooleanExprCheck() {}
+
----------------
LegalizeAdulthood wrote:
> alexfh wrote:
> > Please remove the empty destructor, the top base class has a virtual destructor (we need a check for this as well ;).
> OK.  Most code bases where I've worked had explicit preferences for virtual d'tors to remind readers that the class participates in a virtual method hierarchy.
Fixed.

http://reviews.llvm.org/D8996

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/