[PATCH] [OPENMP] Fixed codegen for arrays in 'copyprivate' clause.

[John McCall]

Thank you.  Two minor notes and LGTM.


================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:101
@@ +100,3 @@
+  // The basic structure here is a do-while loop, because we don't
+  // need to check for the zero-element case.
+  auto BodyBB = createBasicBlock("omp.arraycpy.body");
----------------
I just noticed that this comment is not correct: you are checking for the zero-element case.  I don't know if that's intentional.

================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:125
@@ +124,3 @@
+  auto SrcElement = Builder.CreateConstGEP1_32(SrcElementCurrent, /*Idx0=*/1,
+                                               "omp.arraycpy.src.element");
+  // Check whether we've reached the end.
----------------
Please rename these to DestElementNext and SrcElementNext.

http://reviews.llvm.org/D8914

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/