[PATCH] Add readability-simplify-boolean-expr check to clang-tidy

Richard legalize at xmission.com
Mon Apr 13 11:25:51 PDT 2015


In article <76367d32bace035725762761e5da144f at localhost.localdomain>,

  Alexander Kornienko <alexfh at google.com> writes:

> I'm finally back to work and got around to look at this patch again. The

>  latest changes introduced a few issues (see inline comments). I can fix

>  these and submit the patch for you.


I'm finally able to revisit this, thanks for fixing those issues and
submitting it!

I have a few more polishing patches I'd like to apply to this to
make it more robust.  One is in review right now (chained conditional
assignment/return).  The other bit of polish I would like to apply is
handling when 'static_cast<bool>(e)' should be applied to the resulting
expression in order to preserve semantics in some edge cases.


http://reviews.llvm.org/D7648

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list