r234752 - clang-format: [JS] Allow periods and commata in class declarations.

Daniel Jasper djasper at google.com
Mon Apr 13 07:56:55 PDT 2015


Author: djasper
Date: Mon Apr 13 09:56:54 2015
New Revision: 234752

URL: http://llvm.org/viewvc/llvm-project?rev=234752&view=rev
Log:
clang-format: [JS] Allow periods and commata in class declarations.

Patch by Martin Probst. Thank you.

Modified:
    cfe/trunk/lib/Format/UnwrappedLineParser.cpp
    cfe/trunk/unittests/Format/FormatTestJS.cpp

Modified: cfe/trunk/lib/Format/UnwrappedLineParser.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Format/UnwrappedLineParser.cpp?rev=234752&r1=234751&r2=234752&view=diff
==============================================================================
--- cfe/trunk/lib/Format/UnwrappedLineParser.cpp (original)
+++ cfe/trunk/lib/Format/UnwrappedLineParser.cpp Mon Apr 13 09:56:54 2015
@@ -1541,7 +1541,8 @@ void UnwrappedLineParser::parseRecord()
     // it is often token-pasted.
     while (FormatTok->is(tok::identifier) || FormatTok->is(tok::coloncolon) ||
            FormatTok->is(tok::hashhash) ||
-           (Style.Language == FormatStyle::LK_Java &&
+           ((Style.Language == FormatStyle::LK_Java ||
+             Style.Language == FormatStyle::LK_JavaScript) &&
             FormatTok->isOneOf(tok::period, tok::comma)))
       nextToken();
 

Modified: cfe/trunk/unittests/Format/FormatTestJS.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Format/FormatTestJS.cpp?rev=234752&r1=234751&r2=234752&view=diff
==============================================================================
--- cfe/trunk/unittests/Format/FormatTestJS.cpp (original)
+++ cfe/trunk/unittests/Format/FormatTestJS.cpp Mon Apr 13 09:56:54 2015
@@ -544,6 +544,7 @@ TEST_F(FormatTestJS, ClassDeclarations)
   verifyFormat("class C {\n  private static x: string = 12;\n}");
   verifyFormat("class C {\n  static x(): string { return 'asd'; }\n}");
   verifyFormat("class C extends P implements I {}");
+  verifyFormat("class C extends p.P implements i.I {}");
 }
 
 TEST_F(FormatTestJS, MetadataAnnotations) {





More information about the cfe-commits mailing list