[PATCH] [SEH] Implement filter capturing in CodeGen
Reid Kleckner
rnk at google.com
Mon Apr 6 15:23:42 PDT 2015
================
Comment at: lib/CodeGen/CGException.cpp:95-97
@@ -91,1 +94,5 @@
+ llvm::Type *getExceptionValueType(CodeGenModule &CGM) const {
+ if (this == &MSVC_except_handler || this == &MSVC_C_specific_handler)
+ return CGM.Int32Ty;
+ return CGM.Int8PtrTy;
}
----------------
majnemer wrote:
> Does this deserve a comment or have we documented this somewhere else?
Thanks, that probably deserves a comment.
My thinking was that this more closely mirrors the data that's actually available in the catch block, which is just the exception code in EAX/RAX.
http://reviews.llvm.org/D8825
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list