[PATCH] [Mips] Generate warning for invalid combination of '-mnan' and '-march' options.

Simon Atanasyan simon at atanasyan.com
Thu Apr 2 05:04:24 PDT 2015


================
Comment at: test/Preprocessor/init.c:4419
@@ -4418,3 +4418,1 @@
 //
-// RUN: %clang_cc1 -target-feature +nan2008 \
-// RUN:   -E -dM -triple=mips-none-none < /dev/null \
----------------
vradosavljevic wrote:
> atanasyan wrote:
> > By the way, why do you decide to remove that test at all? Does it fail now?
> It doesn't fail now, but is wrong to pass +nan2008 with the default cpu (mips32r2), because mips32r2 architecture is on the legacy-only list.
Let's pass a correct set of arguments and check that +nan2008 switches on the __mips_nan2008 macro. And maybe additionally check that -nan2008 with the same options switches the macro off.

http://reviews.llvm.org/D8170

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list