Proposed patch adds TLS Max Alignment diagnostic

David Majnemer david.majnemer at gmail.com
Wed Apr 1 19:08:00 PDT 2015


Hi Charles,

Your patch doesn't handle cases where the alignment is dependent,
getDeclAlign doesn't want to be called in such cases:
template <int N>
struct S {
  static int __thread __attribute__((aligned(N))) x;
};

Also, why do you use BaseT->isDependentType() instead of
T->isDependentType()?

On Wed, Apr 1, 2015 at 4:57 PM, Li, Charles <charles_li at playstation.sony.com
> wrote:

>  Hi Clang developers,
>
>
>
> We here at Sony PlayStation have a proposed patch which adds an error
> diagnostic for when TLS variables exceed maximum TLS alignment.
>
> Please note this patch does not affect normal maximum alignments.
>
> This TLS maximum alignment check is currently only turned on for PS4 but
> could potentially be used for other platforms.
>
>
>
> Sincerely,
>
> Charles Li
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150401/f690bb17/attachment.html>


More information about the cfe-commits mailing list