[PATCH] Implement CFI type checks for non-virtual calls.
JF Bastien
jfb at chromium.org
Wed Apr 1 13:46:47 PDT 2015
================
Comment at: test/CodeGenCXX/cfi-nvcall.cpp:31
@@ +30,2 @@
+ c->g();
+}
----------------
Could you add a comment that explains the difference between these two calls to g(), and why the strict check looks for C specifically here whereas the non-strict one accepts A? If c is actually an A then the code is still wrong, but if it's a B then the programmer is technically wrong but a lot of code does this like LLVM itself (I think you had an explanation with examples in an email?).
http://reviews.llvm.org/D8756
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list