[PATCH] libc++: Make support for thread-unsafe C functions optional

[Eric Fiselier]

In http://reviews.llvm.org/D8703#149021, @ed wrote:

> In http://reviews.llvm.org/D8703#148896, @EricWF wrote:
>
> > The CMake and LIT stuff LGTM. However I would rather keep the directory structure in test/std the same as the structure of the C++ standard clauses. Could you rename the fail tests, put them in the correct directories and use `// REQUIRES: libcpp-has-no-thread-unsafe-c-functions`?
>
>
> Sure! Just to make sure I understand it correctly: in this specific case, the tests should be called:
>
>   test/std/utilities/date.time/asctime.fail.cpp
>   test/std/utilities/date.time/ctime.fail.cpp
>   test/std/utilities/date.time/gmtime.fail.cpp
>   test/std/utilities/date.time/localtime.fail.cpp
>   
>
> As in, the same as they are right now, but without the no.thread.unsafe.c.functions component in between?


Pretty much, but I would make the test names more descriptive so they infer that these are failure tests for when we have no unsafe C functions. The test names don't *have* to follow the standard names.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D8703

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/