[PATCH] [OPENMP] Initial codegen for 'parallel for' directive.

John McCall rjmccall at gmail.com
Fri Mar 27 10:34:37 PDT 2015


Looks good overall.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:226
@@ +225,3 @@
+  /// region specified in \a CurrentCodeGenKinds list.
+  void nextCodeGenKind(ArrayRef<OpenMPDirectiveKind> CurrentCodeGenKinds);
+  /// \brief Make current combined region to emit code for \a At OpenMP region
----------------
This is a weird API; its state is half internal (the current index) and half external (the actual array).  It should really own both parts or neither.  For example, I have no idea what the combined region info can actually do with "CurrentKindPos" without knowing the array.

http://reviews.llvm.org/D8631

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list