[PATCH] Make -fsanitize-coverage flag a core option so it's available via the clang-cl driver too

Hans Wennborg hans at chromium.org
Fri Mar 27 09:24:07 PDT 2015


lgtm


================
Comment at: test/Driver/fsanitize.c:238
@@ +237,2 @@
+// CLANG-CL-COVERAGE-NOT: unknown argument
+// CLANG-CL-COVERAGE: -fsanitize=address{{.*}}-fsanitize-coverage=1
----------------
Maybe split the last one into two lines to avoid the {{.*}}? My first thought was hmm, what's that regex supposed to match.

http://reviews.llvm.org/D8663

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list