r233223 - Make the msse4/mno-sse4 flags aliases of the maximum sse values

Eric Christopher echristo at gmail.com
Wed Mar 25 17:41:12 PDT 2015


On Wed, Mar 25, 2015 at 5:35 PM Rafael EspĂ­ndola <rafael.espindola at gmail.com>
wrote:

> > +def mno_sse4 : Flag<["-"], "mno-sse4">, Alias<mno_sse4_1>;
> ...
> > +def msse4 : Flag<["-"], "msse4">, Alias<msse4_2>;
>
>
> The "mno" variant alias 4.1 but the "m" variant alias 4.2? This should
> have a comment :-)
>
>
That's fair. I commented in the commit and I think in the test, but I can
throw it in the code too. It's... subtle. And annoying really :)

-eric


> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150326/14bd6d94/attachment.html>


More information about the cfe-commits mailing list