[PATCH] Command-line options to set debugger "target"

[Paul Robinson]

================
Comment at: lib/Frontend/CompilerInvocation.cpp:408
@@ -407,1 +407,3 @@
 
+  if (Args.hasArg(OPT_ggdb))
+    Opts.setDebugger(llvm::DebuggerKind::GDB);
----------------
dblaikie wrote:
> probinson wrote:
> > dblaikie wrote:
> > > Should this handling be up in the driver? Then it should be easy to write tests for the defaults.
> > No, it should be here, so we can specify a debugger target for -cc1 tests.
> > There aren't any use-cases for that yet, but Katya's import-anonymous-namespace patch could use it, once it goes in.
> Sorry - I mean specifically the cases a few lines down that test isOSDarwin and isPS4CPU - I imagine those should be handled in the driver (sorry, I looked at this block of code & assumed it all dealt with defaults, etc) - and this code should then be simpler and just set the debugger based on which debugger flag is passed down (& possibly rely on the default if no debugger is specified)
Oh, I see.  Yes, that would make sense.

http://reviews.llvm.org/D8599

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/