[PATCH] Refactor: Simplify boolean expression in modularize

David Blaikie dblaikie at gmail.com
Mon Mar 23 12:43:39 PDT 2015


Looks good, committed in r233000

On Sun, Mar 22, 2015 at 1:44 PM, Richard <legalize at xmission.com> wrote:

> Hi alexfh, jtsoftware, rafael, chapuni, dblaikie, bkramer, aprantl,
>
> Simplify boolean expressions using `true` and `false` with `clang-tidy`
>
> http://reviews.llvm.org/D8534
>
> Files:
>   modularize/CoverageChecker.cpp
>
> Index: modularize/CoverageChecker.cpp
> ===================================================================
> --- modularize/CoverageChecker.cpp
> +++ modularize/CoverageChecker.cpp
> @@ -288,7 +288,7 @@
>    int HadErrors = Tool.run(new
> CoverageCheckerFrontendActionFactory(*this));
>
>    // If we had errors, exit early.
> -  return HadErrors ? false : true;
> +  return !HadErrors;
>  }
>
>  // Called from CoverageCheckerCallbacks to track a header included
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150323/272b5c53/attachment.html>


More information about the cfe-commits mailing list