[PATCH] Refactor: Simplify boolean expresssions in lib/Lex

Richard legalize at xmission.com
Sun Mar 22 13:38:06 PDT 2015


Hi alexfh, doug.gregor, akyrtzi, krememek, rsmith,

Simplify boolean expressions using `true` and `false` with `clang-tidy`

http://reviews.llvm.org/D8531

Files:
  lib/Lex/LiteralSupport.cpp

Index: lib/Lex/LiteralSupport.cpp
===================================================================
--- lib/Lex/LiteralSupport.cpp
+++ lib/Lex/LiteralSupport.cpp
@@ -144,7 +144,7 @@
       int CharVal = llvm::hexDigitValue(ThisTokBuf[0]);
       if (CharVal == -1) break;
       // About to shift out a digit?
-      Overflow |= (ResultChar & 0xF0000000) ? true : false;
+      Overflow |= (ResultChar & 0xF0000000);
       ResultChar <<= 4;
       ResultChar |= CharVal;
     }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8531.22441.patch
Type: text/x-patch
Size: 481 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150322/c003d60b/attachment.bin>


More information about the cfe-commits mailing list