[PATCH] Fix source range of defaulted/deleted member declarations

Eli Bendersky eliben at google.com
Fri Mar 20 09:33:23 PDT 2015


In http://reviews.llvm.org/D8465#144139, @jpienaar wrote:

> Looks good. Is it better to adjust the range here or n ParseCXXInlineMethodDef?


The problem with ParseCXXInlineMethodDef is that we no longer have access to these tokens in it. ParseCXXInlineMethodDef expects to see a { for a def or ; for a =default/=delete method. So we'd have to push DeleteOrDefaultEndLoc through to ParseCXXInlineMethodDef - it would result in an additional argument, more code and I'm not sure what gain.


http://reviews.llvm.org/D8465

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list