[PATCH] [PATCH v4] [PowerPC] Add Hardware Transaction Memory builtins support

Bill Schmidt wschmidt at linux.vnet.ibm.com
Thu Mar 19 13:03:20 PDT 2015


This patch LGTM with one minor nit.  Hal, any concerns?


================
Comment at: lib/CodeGen/CGBuiltin.cpp:6408
@@ +6407,3 @@
+      std::stringstream ss;
+      ss << "argument out of range (should be 0 or " << MaxValue << ")";
+      CGM.Error(E->getArg(0)->getExprLoc(), ss.str());
----------------
This will say "(should be 0 or 7)" for the BI__builtin_tsr case.  Please be consistent with the other cases and say "(should be 0-" so this will come out "(should be 0-1)" or "(should be 0-7)".

http://reviews.llvm.org/D8248

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list