[PATCH] Add a diagnostic for PS4 pragma comment

Yunzhong Gao Yunzhong_Gao at playstation.sony.com
Wed Mar 18 18:27:36 PDT 2015


Hi,
PS4 target recognizes the #pragma comment() syntax as in -fms-extensions, but only handles the
case of #pragma comment(lib). This patch adds a warning if any other arguments are encountered.

This patch also refactors the code in ParsePragma.cpp a little bit to make it more obvious that some
codes are being shared between -fms-extensions and PS4 target.

Could someone kindly take a look at the patch?
- Gao

http://reviews.llvm.org/D8432

Files:
  include/clang/Basic/DiagnosticParseKinds.td
  lib/Parse/ParsePragma.cpp
  test/CodeGen/pragma-comment.c
  test/Preprocessor/pragma_ps4.c

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D8432.22237.patch
Type: text/x-patch
Size: 5123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20150319/4798afbd/attachment.bin>


More information about the cfe-commits mailing list