[PATCH] Sema: Accept pointers to any address space for builtin functions
Tom Stellard
thomas.stellard at amd.com
Wed Mar 18 09:46:34 PDT 2015
REPOSITORY
rL LLVM
================
Comment at: lib/Sema/SemaExpr.cpp:4611
@@ +4610,3 @@
+
+ if (!NeedsNewDecl)
+ return nullptr;
----------------
theraven wrote:
> This check looks expensive. Have you profiled this on large codebases with a lot of builtin calls? I'd imagine that adding a DenseMap cache would be faster.
I think the fast-path for builtins without pointers would help here. What keys/data were you thinking would go in the DenseMap?
http://reviews.llvm.org/D8082
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list