[PATCH] [MSVC] Explicit specializations can be declared in any namespace (fix for http://llvm.org/PR13738)

Richard Smith richard at metafoo.co.uk
Tue Mar 17 14:21:28 PDT 2015


REPOSITORY
  rL LLVM

================
Comment at: llvm/tools/clang/lib/Sema/SemaTemplate.cpp:5840
@@ +5839,3 @@
+      int Diag = diag::err_template_spec_redecl_out_of_scope;
+      if (S.getLangOpts().MSVCCompat)
+        Diag = diag::ext_ms_template_spec_redecl_out_of_scope;
----------------
Since this is a non-heinous, conforming extension (and even something that's been suggested for standardization), should it go under `-fms-extensions` not `-fms-compatibility`?

http://reviews.llvm.org/D8283

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list