[PATCH] libc++: Don't let time_put test use implementation dependent constructs
Jonathan Roelofs
jonathan at codesourcery.com
Mon Mar 16 08:38:34 PDT 2015
> Second, some of the tests actually use modifiers that are only present on BSD derived systems. They are not part of the C standard/POSIX. Simply remove them.
They're probably still useful on those platforms... perhaps put them under an #ifdef for that platform, along with a comment saying that they're a bsd extension?
REPOSITORY
rL LLVM
================
Comment at: test/std/localization/locale.categories/category.time/locale.time.put/locale.time.put.members/put2.pass.cpp:186
@@ -185,3 +182,1 @@
{
- iter = f.put(output_iterator<char*>(str), ios, '*', &t, 'B', 'O');
- std::string ex(str, iter.base());
----------------
Can you point to the docs saying that these modifiers are invalid?
http://reviews.llvm.org/D8349
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list