[PATCH] Refactor: Move remove-cstr-calls from a standalone executable to a clang-tidy check readability-redundant-string-cstr

Richard legalize at xmission.com
Sun Mar 15 13:06:26 PDT 2015


================
Comment at: test/clang-tidy/readability-redundant-string-cstr.cpp:24
@@ +23,3 @@
+  // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call to `c_str()` [readability-redundant-string-cstr]
+  // CHECK-FIXES: {{^ *}}f1(s);{{$}}
+}
----------------
alexfh wrote:
> nit: The number of spaces here should remain the same, so I'd better replace `{{^ *}}` with `{{^  }}`.
Fixed

http://reviews.llvm.org/D7318

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list