[PATCH] Make the presence of stdin and stdout optional

Ed Schouten ed at nuxi.nl
Sun Mar 15 01:57:54 PDT 2015


In http://reviews.llvm.org/D8340#140949, @jroelofs wrote:

> This part looks OK.
>
> Is there any value in gating the stdout & stdin bits separately?


The main reason I went for this approach was because I felt that placing it behind one knob would raise the question: "What's so special about these two? Why is stderr treated separately? Why not disable stdin and stderr, or stdout and stderr?" The patch demonstrates that apart from the tying, stdin, stdout and stderr are separate.

That said, I wouldn't mind merging this, as long as we can get a nice compromise between getting the code to work on CloudABI while keeping it readable. Thoughts?


http://reviews.llvm.org/D8340

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list