[PATCH] Adding SmallString support to Twine

Paweł Bylica chfast at gmail.com
Sat Mar 14 14:44:33 PDT 2015


================
Comment at: lib/MC/MCContext.cpp:176-177
@@ -171,4 +175,4 @@
 MCSymbol *MCContext::GetOrCreateSymbol(const Twine &Name) {
   SmallString<128> NameSV;
   return GetOrCreateSymbol(Name.toStringRef(NameSV));
 }
----------------
Do you think it is worth to check if `Name` `isSingleStringRef`?

http://reviews.llvm.org/D6372

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list