[PATCH] MS ABI: Generate default constructor closures

[David Majnemer]

================
Comment at: lib/AST/MicrosoftMangle.cpp:1647
@@ -1645,3 +1646,3 @@
       }
-      Out << "@Z";
+      Out << 'Z';
       return;
----------------
hans wrote:
> This changes from "XX at Z" to "XXZ" for the Ctor_DefaultClosure case. Just double checking that that's intended.
Yep.

================
Comment at: lib/CodeGen/CodeGenTypes.h:268
@@ -268,1 +267,3 @@
+  const CGFunctionInfo &arrangeMSCtorClosure(const CXXConstructorDecl *CD,
+                                                 CXXCtorType CT);
 
----------------
hans wrote:
> nit: indent is off?
Will do.

================
Comment at: test/CodeGenCXX/dllexport.cpp:496
@@ -487,2 +495,3 @@
+};
 
 struct __declspec(dllexport) T {
----------------
hans wrote:
> Add a test where dllexport is on the class rather than the member?
Will do.

http://reviews.llvm.org/D8331

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/