[PATCH] Add commit message guidelines to developer policy
Sean Silva
chisophugis at gmail.com
Thu Mar 12 16:38:43 PDT 2015
I don't think there's consensus about any of this. In particular, it seems like Chandler's feedback in the thread was completely ignored (or not seen). I tend to agree with his points too.
REPOSITORY
rL LLVM
================
Comment at: docs/DeveloperPolicy.rst:299
@@ +298,3 @@
+* `Attribution of Changes`_ should be in a separate line, after the end of
+ the body, as simple as "Patch by John Doe.". This is how we officially
+ handle attribution, and there are automated processes that use that, so
----------------
Please use an exclamation mark like "Patch by John Doe!". For whatever reason this seems to be the way it is usually done. I also kind of like it because I think it expresses our excitement about committing the patch for a new contributor (new contributors are vital for community growth).
http://reviews.llvm.org/D8197
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the cfe-commits
mailing list