[PATCH] [OPENMP] Initial codegen for 'omp sections' and 'omp section' directives.

John McCall rjmccall at gmail.com
Thu Mar 12 00:53:03 PDT 2015


Looks good.  A couple minor requests:


================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:306
@@ -307,1 +305,3 @@
+  // Emit condition.
+  llvm::Value *BoolCondVal = EvaluateExprAsBool(LoopCond);
   Builder.CreateCondBr(BoolCondVal, LoopBody, ExitBlock,
----------------
It's better to use EmitBranchOnBoolExpr here.

================
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:772
@@ +771,3 @@
+                                         OMPC_SCHEDULE_static);
+  } else
+    // If only one section is found - no need to generate loop, emit as a single
----------------
Braces.

http://reviews.llvm.org/D8244

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list