FW: [OpenCL][Patch] This patch adds OpenCL checks in OpenCL address space conversion rules

Anastasia Stulova anastasia.stulova at arm.com
Wed Mar 11 11:45:07 PDT 2015


Yes. I will change that to be consistent with the rest!

Thanks,
Anastasia

-----Original Message-----
From: Pekka Jääskeläinen [mailto:pekka.jaaskelainen at tut.fi] 
Sent: 11 March 2015 18:30
To: cfe-commits at cs.uiuc.edu; Anastasia Stulova
Subject: Re: FW: [OpenCL][Patch] This patch adds OpenCL checks in OpenCL
address space conversion rules

LGTM except lhsPtr should start with a capital letter? ;]

On 02/17/2015 12:40 PM, Anastasia Stulova wrote:
> Ping!
>
> *From:*cfe-commits-bounces at cs.uiuc.edu 
> [mailto:cfe-commits-bounces at cs.uiuc.edu]
> *On Behalf Of *Anastasia Stulova
> *Sent:* 12 February 2015 17:27
> *To:* cfe-commits at cs.uiuc.edu
> *Subject:* [OpenCL][Patch] This patch adds OpenCL checks in OpenCL 
> address space conversion rules
>
> Recently committed OpenCL specific address space conversion rules 
> broke Clang address space extension for C.
>
> This patch fixes the problem by checking for OpenCL and adds the 
> missing test code that identifies this failure.
>
> Thanks to Manuel Jacob who spotted this problem!
>
> Regards,
>
> Anastasia








More information about the cfe-commits mailing list