[PATCH] [clang-tidy] Static Analyzer checker configuration options passthrough

Alexander Kornienko alexfh at google.com
Wed Mar 11 06:11:20 PDT 2015


================
Comment at: clang-tidy/ClangTidy.cpp:218
@@ +217,3 @@
+        OptName.substr(AnalyzerPrefix.size(), Pos - AnalyzerPrefix.size());
+    AnalyzerOptions->Config[(Twine(AnalyzerCheckName) + ":" +
+                             OptName.substr(Pos + 1)).str()] = Opt.second;
----------------
xazax.hun wrote:
> alexfh wrote:
> > Can we just use the same format in clang-tidy options (prepended with 'clang-analyzer-')? 
> Unfortunately if colons are present in the key of a config option, there will be an yaml error message: unexpected ':'. It might be possible to escape it somehow but I find it an uglier solution, so I went ahead with the period syntax. It is more consistent with the tidy checker configuration syntax anyways.
I think, the consistency between the syntax here and in the `-analyzer-config` analyzer command-line option is more important than the negligible inconvenience of having to enclose option names in quotes. Option values frequently require quotes anyway.

http://reviews.llvm.org/D8164

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list