r231892 - For PR22870: produce an error rather than asserting if a designated initializer appears in a signature.

Richard Smith richard-llvm at metafoo.co.uk
Tue Mar 10 17:12:17 PDT 2015


Author: rsmith
Date: Tue Mar 10 19:12:17 2015
New Revision: 231892

URL: http://llvm.org/viewvc/llvm-project?rev=231892&view=rev
Log:
For PR22870: produce an error rather than asserting if a designated initializer appears in a signature.

Added:
    cfe/trunk/test/CodeGenCXX/mangle-fail.cpp
Modified:
    cfe/trunk/lib/AST/ItaniumMangle.cpp

Modified: cfe/trunk/lib/AST/ItaniumMangle.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ItaniumMangle.cpp?rev=231892&r1=231891&r2=231892&view=diff
==============================================================================
--- cfe/trunk/lib/AST/ItaniumMangle.cpp (original)
+++ cfe/trunk/lib/AST/ItaniumMangle.cpp Tue Mar 10 19:12:17 2015
@@ -2673,7 +2673,6 @@ recurse:
   // These all can only appear in local or variable-initialization
   // contexts and so should never appear in a mangling.
   case Expr::AddrLabelExprClass:
-  case Expr::DesignatedInitExprClass:
   case Expr::ImplicitValueInitExprClass:
   case Expr::ParenListExprClass:
   case Expr::LambdaExprClass:
@@ -2685,6 +2684,7 @@ recurse:
   case Expr::BlockExprClass:
   case Expr::ChooseExprClass:
   case Expr::CompoundLiteralExprClass:
+  case Expr::DesignatedInitExprClass:
   case Expr::ExtVectorElementExprClass:
   case Expr::GenericSelectionExprClass:
   case Expr::ObjCEncodeExprClass:

Added: cfe/trunk/test/CodeGenCXX/mangle-fail.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/mangle-fail.cpp?rev=231892&view=auto
==============================================================================
--- cfe/trunk/test/CodeGenCXX/mangle-fail.cpp (added)
+++ cfe/trunk/test/CodeGenCXX/mangle-fail.cpp Tue Mar 10 19:12:17 2015
@@ -0,0 +1,26 @@
+// RUN: %clang_cc1 -emit-llvm -x c++ -std=c++11 -verify %s -DN=1
+// RUN: %clang_cc1 -emit-llvm -x c++ -std=c++11 -verify %s -DN=2
+// RUN: %clang_cc1 -emit-llvm -x c++ -std=c++11 -verify %s -DN=3
+
+struct A { int a; };
+
+#if N == 1
+// ChooseExpr
+template<class T> void test(int (&)[sizeof(__builtin_choose_expr(true, 1, 1), T())]) {} // expected-error {{cannot yet mangle}}
+template void test<int>(int (&)[sizeof(int)]);
+
+#elif N == 2
+// CompoundLiteralExpr
+template<class T> void test(int (&)[sizeof((A){}, T())]) {} // expected-error {{cannot yet mangle}}
+template void test<int>(int (&)[sizeof(A)]);
+
+#elif N == 3
+// DesignatedInitExpr
+template<class T> void test(int (&)[sizeof(A{.a = 10}, T())]) {} // expected-error {{cannot yet mangle}}
+template void test<int>(int (&)[sizeof(A)]);
+
+// FIXME: There are several more cases we can't yet mangle.
+
+#else
+#error unknown N
+#endif





More information about the cfe-commits mailing list