[PATCH] [PATCH v3] [PowerPC] Add Hardware Transaction Memory builtins support

Bill Schmidt wschmidt at linux.vnet.ibm.com
Tue Mar 10 14:08:19 PDT 2015


One inline comment.  I have not checked the two header files in detail, but I assume you have worked with bergner on those.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:6406
@@ +6405,3 @@
+    if (CI->getZExtValue() > MaxValue) {
+      CGM.ErrorUnsupported(E->getArg(0), "argument out of range (should be 0 or 1)");
+      return llvm::UndefValue::get(Ops[0]->getType());
----------------
This error message is still wrong for BI__builtin_tsr.

http://reviews.llvm.org/D8226

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list