[PATCH] Copy data files to the remote runner.

Dan Albert danalbert at google.com
Tue Mar 10 13:38:29 PDT 2015


================
Comment at: test/libcxx/test/executor.py:113
@@ -112,2 +112,3 @@
         target_cwd = None
+        data_files = [f for f in os.listdir(work_dir) if f.endswith('.dat')]
         try:
----------------
jroelofs wrote:
> This feels like it's at the wrong level of abstraction. Shouldn't the "which files do I copy in" part be determined by the caller?
Good point. New version moves this responsibility up.

http://reviews.llvm.org/D8118

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list