[libcxx] r231649 - Add CloudABI locale names to platform_support.h.
Jonathan Roelofs
jonathan at codesourcery.com
Tue Mar 10 06:48:29 PDT 2015
On 3/10/15 1:57 AM, Ed Schouten wrote:
> Hi Jonathan,
>
> 2015-03-10 0:25 GMT+01:00 Jonathan Roelofs <jroelofs.lists at gmail.com>:
>> I don't know how much of the tests you've got running at the moment, but
>> there's a corresponding change needed to the lit config to get the xfails
>> for these to DoTheRightThing TM:
>> https://github.com/llvm-mirror/libcxx/blob/master/test/libcxx/test/config.py#L236
>
> Exactly. I made some local modifications to config.py to at least make
> the test suite run, but so far these patches are too poor to
> integrate. With all source patches applied I can get to a state where
> all tests minus ~200 pass.
>
> The code you linked to is a bit problematic in my case because it
> inspects the host system to determine which locales are present, while
> CloudABI is only intended to be a cross compilation target for now
> (having its own locale implementation and data). I'll see what I can
> do.
>
Ah, in that case, you should subclass this:
https://github.com/llvm-mirror/libcxx/blob/master/test/libcxx/test/target_info.py#L5
and then add -DLIBCXX_TARGET_INFO="libcxx.test.CloudABITargetInfo" to
your cmake configuration line.
Cheers,
Jon
--
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded
More information about the cfe-commits
mailing list