[PATCH] [PPC64] Add 64-bit Vector Integer Arithmetic Instructions

Nemanja Ivanovic nemanja.i.ibm at gmail.com
Mon Mar 9 15:01:46 PDT 2015


================
Comment at: include/clang/Basic/BuiltinsPPC.def:96
@@ -92,1 +95,3 @@
+BUILTIN(__builtin_altivec_vmulosw, "V2SLLiV4SiV4Si", "")
+BUILTIN(__builtin_altivec_vmuluwm, "V4UiV4UiV4Ui", "")
 
----------------
Is this the underlying builtin for the removed vec_muluwm? Should this be removed as well if so? The diff does not show any calls for this (i.e. in altivec.h or the test case).

================
Comment at: include/clang/Basic/DiagnosticParseKinds.td:359
@@ +358,3 @@
+  "use of 'long long' with '__vector bool' requires VSX support (available on "
+  "the POWER7 or later) or extended Altivec support (available on the POWER8 " 
+  "or later) to be enabled">;
----------------
Can we fix this message since the word "the" is out of place?
"available on POWER7 or later"
"available on POWER8 or later"

http://reviews.llvm.org/D8041

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list