[PATCH] Add support for armv6k subtarget

Renato Golin renato.golin at linaro.org
Sat Mar 7 05:50:02 PST 2015


You don't seem to be dealing with v6Z or v6KZ at all, but LLVM does and your tests do, too. Shouldn't you make sure the arch/cpu relationships maintained in LLVM to be the same here?


================
Comment at: lib/Driver/ToolChains.cpp:113
@@ -112,2 +112,3 @@
   return llvm::StringSwitch<const char*>(Value)
-    .Case("armv6k", "armv6")
+    .Case("armv6", "armv6")
+    .Case("armv6k", "armv6k")
----------------
Isn't there a default to keep the same name?

http://reviews.llvm.org/D8127

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the cfe-commits mailing list